Skip to content

Conversation

@martinflorian-da
Copy link
Contributor

We still reference those in places, such as cncluster and CircleCI flows...

And they don't look secret to me; so let's push now to fix things and clean up later.

Fixes https://github.com/DACH-NY/cn-test-failures/issues/4472

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

We still reference those in places, such as `cncluster` and CircleCI flows...

And they don't look secret to me; so let's push now to fix things and clean up later.

Fixes DACH-NY/cn-test-failures#4472

[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
martinflorian-da added a commit that referenced this pull request Jun 6, 2025
s.a. #1032

[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
@martinflorian-da martinflorian-da merged commit df2961f into main Jun 6, 2025
41 checks passed
@martinflorian-da martinflorian-da deleted the martinflorian-da/cntf-4472-fix-reonboarding-test branch June 6, 2025 14:47
github-actions bot pushed a commit that referenced this pull request Jun 10, 2025
We still reference those in places, such as `cncluster` and CircleCI flows...

And they don't look secret to me; so let's push now to fix things and clean up later.

Fixes DACH-NY/cn-test-failures#4472

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
@github-actions
Copy link

Backport to branch release-line-0.4.1 failed. Please check the logs for more information.

stephencompall-DA pushed a commit that referenced this pull request Jun 10, 2025
We still reference those in places, such as `cncluster` and CircleCI flows...

And they don't look secret to me; so let's push now to fix things and clean up later.

Fixes DACH-NY/cn-test-failures#4472

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
stephencompall-DA added a commit that referenced this pull request Jun 10, 2025
We still reference those in places, such as `cncluster` and CircleCI flows...

And they don't look secret to me; so let's push now to fix things and clean up later.

Fixes DACH-NY/cn-test-failures#4472

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Co-authored-by: Martin Florian <martin.florian@digitalasset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants